Skip to content

feat: #1297 Improve focus behavior #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 6, 2025
Merged

feat: #1297 Improve focus behavior #1453

merged 17 commits into from
Jan 6, 2025

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Jan 1, 2025 •
edited
Loading

Connection with issue(s)

Close #1296
Close #1290
Close #1301
Close #1304
Close #1292

Connected #1297
Solve partially #1450

Solution description

Knowledge base

Unsolved issues

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.12919% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (3ef4125) to head (125f1a7).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/fields/form_builder_filter_chips.dart 90.47% 2 Missing ⚠️
lib/src/form_builder_field.dart 0.00% 2 Missing ⚠️
lib/src/fields/form_builder_checkbox_group.dart 92.30% 1 Missing ⚠️
lib/src/fields/form_builder_radio_group.dart 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
+ Coverage   88.15%   90.09%   +1.93%     
==========================================
  Files          21       21              
  Lines         777      828      +51     
==========================================
+ Hits          685      746      +61     
+ Misses         92       82      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias mentioned this pull request Jan 5, 2025
Closed
7 tasks
@deandreamatias deandreamatias self-assigned this Jan 5, 2025
@deandreamatias deandreamatias linked an issue Jan 5, 2025 that may be closed by this pull request
[General]: Focus behaviour navigating using tab on conditional fields #1290
Closed
7 tasks
@deandreamatias deandreamatias marked this pull request as ready for review January 5, 2025 23:03
This was referenced Jan 5, 2025
Closed
Closed
@deandreamatias deandreamatias merged commit e2876c9 into main Jan 6, 2025
6 checks passed
@deandreamatias deandreamatias deleted the feature/1297-improve-focus branch January 6, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@deandreamatias deandreamatias

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

@deandreamatias